Repository navigation
Complete Lane G planning acceptance - #152
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The composed acceptance and supporting documentation consistently satisfy the stated G4 completion criteria.
0 open findings
What changed in this PR
Completes Lane G/T18 planning acceptance across browser, provider, HTTP lifecycle, and durable SQLite storage.
Changes:
- Adds composed production planning browser acceptance.
- Verifies prompt context, schema mounting, restart persistence, and Store reopening.
- Marks G4 and T18 complete with reconciled Codex-refusal documentation.
| File | Description |
|---|---|
test/browser/plans-production.spec.ts |
Adds end-to-end production planning acceptance. |
docs/implementation/planning-screen.md |
Documents G4 integration and coverage. |
docs/implementation/planning-acceptance.md |
Records T18 completion evidence. |
docs/designs/codeboost-plan-indexed-review.md |
Updates T18 status and Codex criteria. |
docs/architecture.md |
Marks Lane G complete. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mchwang
marked this pull request as ready for review
October 8, 2026 23:26
This was referenced Oct 10, 2026
mchwang
added a commit
that referenced
this pull request
Oct 10, 2026
* Close out Lane G status records (#145) Lane G (G1-G4) merged in PRs #148, #150, #151 and #152. The README and the design overview still described the Planning screen as unbuilt, and build step 6 said "no screen yet". Record the screen as built, mark build step 6 done, and record Lane G's release of the shared web files plus the remaining lane F follow-up (#146) in the planning-screen document. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Point lane status readers to the live table; name released files (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Clarify Lane G handoff and screen name (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Tighten Lane G handoff wording (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Mark lane G done in the Wave 2 table; state #146 ownership source (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Name the web files lane G released in the Wave 2 table (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Put the finished lane G row in the past tense (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drop unneeded history from the lane G row (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Match the H row layout; cite where #146 is assigned to lane F (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * README: planning agent needs a github review, not the demo (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Clarify met G4 condition and demo limits (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Put wave 2 ownership rules in the past tense (#145) Copilot round 1 found that the Wave 2 note and integration rule 2 still gave G active ownership of web files the handoff says were released. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Record where H4a's web files went after G1 (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Name G3's one web/server.ts change in the handoff records (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Put the H4a ownership bullet in the past tense (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Name F's wave 2 server files in integration rule 2 (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Remove unneeded ownership history; quote the AGENTS.md rule (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Keep only supported ownership history (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Describe wave 1 config ownership as the plan's (#145) Copilot round 2 found that rule 2 still stated C's and D's finished wave 1 assignments as active rules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Mark the lane plans as the original schedule (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Link the Lane G close-out follow-ups (#155, #156) (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * List all open Lane G follow-ups in the handoff (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Note what the Plans screen does for amendments today (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Match the handoff to #155's scope (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Update next steps and menu-link status for the Plans screen (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Describe the built Dismiss control in plan-format (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Match plan-format's Plans screen controls to the built screen (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Mark unbuilt Plans screen design features (#155) (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Match the handoff to #155's widened scope (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Name the suggestion Apply control; date the Plans DT update (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Correct the amendment and Settings notes (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Qualify build step 6 status with #155's unbuilt parts (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Place the refresh line below the cards in plan-format (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Qualify the Plans screen in What to do next (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Say the Plans screen has no approval step yet (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * List the approval step among #155's unbuilt parts (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Put lane H's ownership section in the past tense (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Put the H4b bullet in the past tense (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Keep H4b's storage note as the original plan (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Keep plan-format's v1 contract text; list shipped differences separately (#145) Copilot round 3: the guide's suggestion-card wording had been changed to match the shipped screen, which conflicts with the immutable v1 contract (schema/versions/1/semantics.md). Restore the contract-mirroring text, describe what the shipped screen does in its own section, and track the non-conformance in #159. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Cite #159 in status lines; note the #146 import limit (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * List the amendment-proposal gap in plan-format's shipped section (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Record that #146 was fixed by PR #158 (#145) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
productionPlanning, the D-backedcreatePlanningProviderboundary, F's production HTTP lifecycle and the SQLite StoreTracks #145. This is the G4 completion PR.
Done when
npx playwright test test/browser/plans-production.spec.ts && npx vitest run test/planning-provider.test.ts test/planning-production.test.ts test/planning-recorded.test.ts && npm run typecheckpasses, andtest/agent-planning.test.tspasses on the exact head after the active F5 owner releases heavyweight Docker validation.Validation
Exact base/head:
89707f86de76ca71060ae0a07496faf084d46088→d22609c6e9ecaae3f52a0f33829d1908441833abReview record
89707f8..11cf81d: found two valid P2s. The composed test did not assert enough of the captured prompt, and the architecture completion wording conflicted with T18's source checklist.89707f8..23a1798: clean, with both prior findings resolved and no new findings.agent-planning.test.tspassed 1/1; the three source-of-truth status records were changed from pending to complete.89707f8..d22609c: clean; both earlier findings remain resolved and the Lane G/T18 completion evidence is consistent.d22609c: approval recommended, 0 open findings; no earlier valid finding remains unresolved.Review-lesson audit
AGENTS.md/CLAUDE.mdrule is needed.Integration note
PR #149 also edits
docs/architecture.mdand has already integrated the G3 version from main. Whichever branch integrates second must preserve both F5/F6 status and G4's final Lane G status rather than choosing one side wholesale.